Re: [GIT PULL] SCSI fixes for 4.18-rc3
Linus Torvalds writes: (Summary) I'd rather add a deprecation warning to the whole "read/write to /dev/sg" itself, and then do what we did for ib_safe_file_access(), which was to just have the...
View ArticleRe: [GIT PULL] SCSI fixes for 4.18-rc3
Linus Torvalds writes: (Summary) On Fri, Jul 6, 2018 at 7:39 PM Linus Torvalds<torvalds@linux-foundation.org> wrote:[...] to /dev/sg" itself In the meantime, I've pulled this, but do wonder why...
View ArticleRe: [GIT PULL] SCSI fixes for 4.18-rc3
Linus Torvalds writes: (Summary) I'm not part of it even as the primary user, so.. as the primary user, so.. Anyway, cdrom devices are definitely *not* a reason for using /dev/sg*, exactly because no...
View ArticleRe: Crypto Fixes for 4.18
Linus Torvalds writes: (Summary) On Sun, Jul 8, 2018 at 9:20 AM Herbert Xu <herbert@gondor.apana.org.au> wrote: [...] - Add missing RETs in x86 aegis/morus. Side note - I queried earlier during...
View ArticleRe: [PATCH for 4.18 0/6] Restartable Sequences updates
Linus Torvalds writes: On Sun, Jul 8, 2018 at 2:03 PM Mathieu Desnoyers<mathieu.desnoyers@efficios.com> wrote:[...] rseq __get_user/__put_user for get_user/put_user as discussed. LGTM, FWIW. I...
View ArticleLinux 4.18-rc4
Linus Torvalds writes: (Summary) Srinivasan (1): x86/hyper-v: Fix the circular dependency in IPI enlightenment Kees Cook (1): bus: ti-sysc: Use 2-factor allocator arguments Kleber Sacilotto de Souza...
View ArticleRe: Crypto Fixes for 4.18
Linus Torvalds writes: On Mon, Jul 9, 2018 at 2:47 AM Ondrej Mosn=C3=A1=C4=8Dek <omosnacek+linux-crypto@gmail.com> wrote:[...] testing, but because by sheer luck it was "working" anyway... Thanks...
View ArticleRe: [PATCH for 4.18 2/6] rseq: use get_user/put_user rather than _ ...
Linus Torvalds writes: (Summary) On Mon, Jul 9, 2018 at 10:28 AM Mathieu Desnoyers<mathieu.desnoyers@efficios.com> But when I started looking, it turns out that yeah, we do "copy_from_user()" on...
View ArticleRe: [PATCH for 4.18 2/6] rseq: use get_user/put_user rather than _ ...
Linus Torvalds writes: On Mon, Jul 9, 2018 at 11:19 AM Mathieu Desnoyers<mathieu.desnoyers@efficios.com> wrote:[...] the lot with get_user/put_user/copy_{from,to}_user ? Do the full replacement,...
View ArticleRe: [PATCH v2 2/2] drivers: core: Remove glue dirs from sysfs earlier
Linus Torvalds writes: (Summary) On Mon, Jul 9, 2018 at 5:29 PM Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:[...] This directory is never "explicitely" removed when empty however,...
View ArticleRe: [GIT PULL] SCSI fixes for 4.18-rc3
Linus Torvalds writes: (Summary) 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index cd2fdac000c9..09325b8fbc9f 100644...
View ArticleRe: [GIT PULL] SCSI fixes for 4.18-rc3
Linus Torvalds writes: (Summary) On Tue, Jul 10, 2018 at 10:36 AM Jann Horn <jannh@google.com> wrote: [...] that's not a practical concern. Right. I don't expect it to trigger at all, and the...
View ArticleRe: [PATCH v35 1/5] mm: support to get hints of free page blocks
Linus Torvalds writes: (Summary) wrote: [...] + buf = (__le64 *)page_address(buf_page); Stop this garbage. Stop this garbage. Why the hell would you pass in some crazy "liost of pages" that uses that...
View ArticleRe: [GIT PULL] SCSI fixes for 4.18-rc3
Linus Torvalds writes: On Tue, Jul 10, 2018 at 10:49 AM Linus Torvalds<torvalds@linux-foundation.org> wrote:[...] of them would be ok, but /dev/sd3 is right out". Actually, I don't want to after...
View ArticleRe: Re: [GIT PULL] SCSI fixes for 4.18-rc3
Linus Torvalds writes: (Summary) It will do a sg_scsi_ioctl(), but before that it does the same crazy sg_allow_access() case - and only for read-only opens. for read-only opens. But that's *doubly*...
View ArticleRe: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superb ...
Linus Torvalds writes: (Summary) The part that matters i= s using just one syscall to do the whole thing. s using just one syscall to do the whole thing. Please no. In other words, replace...
View ArticleRe: [PATCH v35 1/5] mm: support to get hints of free page blocks
Linus Torvalds writes: (Summary) wrote: [...] in multiple such max arrays (a list of them). No. No. Stop this already./ Stop this already./ You're doing everthing wrong. You're doing everthing wrong....
View ArticleRe: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superb ...
Linus Torvalds writes: (Summary) yeah, we have that for writes in general. yeah, we have that for writes in general. Nobody ever actually follows that rule. They may *think* they do, and then they call...
View ArticleRe: [RFC][PATCH 04/42] make get_empty_filp() to call file_free_rcu ...
Linus Torvalds writes: This one looked odd to me. This one looked odd to me. Then I saw 5/42, and it made more sense. Then I saw 5/42, and it made more sense. I think the explanation is a bit...
View ArticleRe: [RFC][PATCH 08/42] make sure do_dentry_open() won't return pos ...
Linus Torvalds writes: On Tue, Jul 10, 2018 at 7:23 PM Al Viro <viro@zeniv.linux.org.uk> wrote: [...] + } Can we please do this as Can we please do this as if (WARN_ON_ONCE(error > 0)) error =...
View Article