Quantcast
Channel: lkml.org : Ganesh Sittampalam
Browsing all 627 articles
Browse latest View live
↧

Re: [RFC][PATCH 16/42] now we can fold open_check_o_direct() into ...

Linus Torvalds writes: (Summary) I like the patch, I hate the commit message. I like the patch, I hate the commit message. It makes sense right now in this sequence, but I'd really like the commit...

View Article


Re: [RFC][PATCH 01/42] drm_mode_create_lease_ioctl(): fix open-cod ...

Linus Torvalds writes: (Summary) Ok, you didn't seem to have a coverletter email, so I'm just replying to the first one. to the first one. Apart from the couple of totally trivial things I reacted to,...

View Article


Re: [RFC][PATCH 10/11] signal: Push pid type from signal senders d ...

Linus Torvalds writes: (Summary) Biederman wrote:[...] or a single thread. Ahh. Ahh. This is much nicer than what I was playing with yesterday, trying to separate out the "bool group" logic in the...

View Article

Re: [RFC][PATCH 16/42] now we can fold open_check_o_direct() into ...

Linus Torvalds writes: On Tue, Jul 10, 2018 at 7:59 PM Al Viro <viro@zeniv.linux.org.uk> wrote: [...] Umm... Something like [..] Ack. Ack. Linus Linus Linus

View Article

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks an ...

Linus Torvalds writes: (Summary) wrote: [...] 7.81% context_switch [kernel.kallsyms] [k] cgroup_rstat_updated Oh, see that's the difference. Oh, see that's the difference. You're running in a non-root...

View Article


Re: [PATCH] random: fix rdrand mix-in

Linus Torvalds writes: (Summary) wrote: [...] compiler points out that the data is uninitialized in this case: Ack. Ack. Except: Except:[...] } Why not just make that "continue" be a "break"? If you...

View Article

Re: [RFC][PATCH 07/11] signal: Deliver group signals via PIDTYPE_T ...

Linus Torvalds writes: (Summary) On Mon, Jul 16, 2018 at 7:50 AM Eric W. wrote: [...] can change it without creating a regression. Actually, there's a really obvious case where this simply isn't true....

View Article

Re: dvb usb issues since kernel 4.9

Linus Torvalds writes: (Summary) wrote: [...] do its job" is problematic patch. Ok, this thread died down without any resolution. Ok, this thread died down without any resolution.[...] proposed by...

View Article


Re: [PATCH v2] tools/memory-model: Add extra ordering for locks an ...

Linus Torvalds writes: (Summary) The AIX documentation implies that the *sequence* of load-compare-conditional branch-isync is a memory barrier, even if isync on its own is now. barrier, even if isync...

View Article


Re: [PATCH v2] tools/memory-model: Add extra ordering for locks an ...

Linus Torvalds writes: (Summary) BUT, this is where isync comes in: BUT, this is where isync comes in:[...] NOT be done earlier than stores outside of it!). which is why I think that a spinlock...

View Article

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks an ...

Linus Torvalds writes: On Tue, Jul 17, 2018 at 12:37 PM Alan Stern <stern@rowland.harvard.edu> wrote: [...] region. Hmm, yes of course. But the isync instruction description I found also talks...

View Article

Re: [PATCH] random: fix rdrand mix-in

Linus Torvalds writes: (Summary) On Tue, Jul 17, 2018 at 2:12 PM Theodore Y. wrote: [...] _maybe_ you could exhaust the HW entropy). I suspect you can't hit it in practice on Intel systems, but maybe...

View Article

Re: [RFC] call_with_creds()

Linus Torvalds writes: (Summary) So now you take a subtle bug, and make it even more subtle, and encourage people to do this known-broken model of using creds at IO time. No. No. Some debugging option...

View Article


Re: [RFC] call_with_creds()

Linus Torvalds writes: (Summary) But then the problem is that you're doing the open() itself in the wrong context, and that has nothing to do with any general issue, and everything to do with "you...

View Article

Re: [RFC] call_with_creds()

Linus Torvalds writes: (Summary) So on the one hand, in this case I'd actually be more ok with the whole "call_with_creds()" model, because open() is actually *supposed* to use creds. to use creds. At...

View Article


Re: [RFC] call_with_creds()

Linus Torvalds writes: On Wed, Jul 18, 2018 at 2:22 PM Al Viro <viro@zeniv.linux.org.uk> wrote: [...] Why is counter any better than LSB of a pointer? Easier nesting, but if you do it with the...

View Article

Re: [RFC] call_with_creds()

Linus Torvalds writes: (Summary) Of course, you may well have reasons why you actually want to cache the key itself (and hide it in private_data or similar rather than look it up, but if looking it up...

View Article


Re: [RFC] call_with_creds()

Linus Torvalds writes: (Summary) wrote: [...] down. It should always be there in the 'struct file *'. It should always be there in the 'struct file *'. Now, we may have some broken stuff that passes...

View Article

Re: [PATCH 08/10] psi: pressure stall information for CPU, memory, ...

Linus Torvalds writes: (Summary) wrote: [...] Leaving us just 5 bytes short of needing a single cacheline :/ Do you actually need 64 bits for the times? Do you actually need 64 bits for the times?...

View Article

Re: [PATCH 1/3] perf/core: Make sure the ring-buffer is mapped in ...

Linus Torvalds writes: (Summary) On Fri, Jul 20, 2018 at 3:20 PM Andy Lutomirski <luto@amacapital.net> wrote= [...] IRET and re-enable NMIs on the way out.[...] n 32-bit and 64-bit for quite a...

View Article
Browsing all 627 articles
Browse latest View live