Quantcast
Channel: lkml.org : Ganesh Sittampalam
Viewing all articles
Browse latest Browse all 627

Re: [PATCH v35 1/5] mm: support to get hints of free page blocks

$
0
0
Linus Torvalds writes: (Summary) wrote:

[...]

+ buf = (__le64 *)page_address(buf_page);
Stop this garbage.
Stop this garbage.
Why the hell would you pass in some crazy "liost of pages" that uses that lru list?
that lru list?
That's just insane shit.
That's just insane shit.
Just pass in a an array to fill in. If you want to do it in a page, do it with
you want to do it in a page, do it with
u64 *array = page_address(page);
int nr = PAGE_SIZE / sizeof(u64);
int nr = PAGE_SIZE / sizeof(u64);
and now you pass that array in to the thing.

Viewing all articles
Browse latest Browse all 627

Trending Articles