Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executi ...
Linus Torvalds writes: (Summary) On Fri, Mar 16, 2018 at 4:48 AM, Borislav Petkov <bp@alien8.de> The "address" register contains the CR2 value as it was read *very* early in the page fault case,...
View ArticleRe: [PATCH v5 0/2] Remove false-positive VLAs when using max()
Linus Torvalds writes: (Summary) And no, using "-Werror=3Dvla-larger-than=3D1" doesn't work either, because the moronic compiler continues to think that "vla" is about the _type_, not the code: _type_,...
View ArticleRe: [PATCH v5 0/2] Remove false-positive VLAs when using max()
Linus Torvalds writes: (Summary) - */ - -/** - * min_t - return minimum of two values, using the specified type - * @type: data type to use - * @x: first value - * @y: second value - */ -#define...
View ArticleRe: [PATCH -next 00/22] remove in-kernel syscall invocations (part ...
Linus Torvalds writes: (Summary) That sucks, because you have two choices: - either pointlessly generate extra code for the 200+ system calls that are *not* used by the kernel that are *not* used by...
View ArticleRe: [PATCH v5 0/2] Remove false-positive VLAs when using max()
Linus Torvalds writes: (Summary) On Fri, Mar 16, 2018 at 1:03 PM, Miguel Ojeda<miguel.ojeda.sandonis@gmail.com> wrote:[...]https://godbolt.org/ Well, my *test* code works on that one and -Wvla...
View ArticleRe: [PATCH v5 0/2] Remove false-positive VLAs when using max()
Linus Torvalds writes: (Summary) wrote: [...] That's C99, straight from N1256.pdf (C99-TC3)... I checked C90, since the error is I checked C90, since the error is ISO C90 forbids variable length array...
View ArticleRe: [PATCH v5 0/2] Remove false-positive VLAs when using max()
Linus Torvalds writes: On Fri, Mar 16, 2018 at 1:14 PM, Linus Torvalds<torvalds@linux-foundation.org> wrote:[...] __builtin_choose_expr() simply didn't exist back then. No, that goes further...
View ArticleRe: [PATCH v5 0/2] Remove false-positive VLAs when using max()
Linus Torvalds writes: (Summary) wrote: [...] That is probably missing optimisation. Looking at the code is definitely an option. Looking at the code is definitely an option. In fact, instead of...
View ArticleRe: [PATCH] mm: add config for readahead window
Linus Torvalds writes: (Summary) wrote:[...] IIRC, Linus was against it. I have never seen any valid situation that wasn't tuning for one odd machine, usually with a horribly crappy disk setup and very...
View ArticleRe: what the hell is compat_sys_x86_waitpid() for?
Linus Torvalds writes: (Summary) wrote: [...] it was (and always had been) 100% pointless. That long long predates Dominik's patches, though. That long long predates Dominik's patches, though. It...
View ArticleRe: [PATCH v5 0/2] Remove false-positive VLAs when using max()
Linus Torvalds writes: (Summary) wrote: [...] =E2=80=99:[...] =E2=80=98__builtin_choose_expr=E2=80=99 not a constant Ok, so it really looks like that same "__builtin_constant_p() doesn't return a...
View ArticleRe: [RFC PATCH 3/6] fs: provide generic compat_sys_p{read,write}64 ...
Linus Torvalds writes: (Summary) Honestly, I think the patches like this are disgusting: Honestly, I think the patches like this are disgusting: On Sun, Mar 18, 2018 at 9:10 AM, Dominik...
View ArticleRe: [RFC PATCH 4/6] mm: provide generic compat_sys_readahead() imp ...
Linus Torvalds writes: (Summary) This is still too ugly to live. What *may* be acceptable is if architectures defined something like this: What *may* be acceptable is if architectures defined something...
View ArticleRe: [RFC PATCH 2/6] fs: provide a generic compat_sys_truncate64() ...
Linus Torvalds writes: (Summary) On Sun, Mar 18, 2018 at 9:10 AM, Dominik Brodowski<linux@dominikbrodowski.net> wrote:[...] +#endif /* __ARCH_WANT_COMPAT_SYS_TRUNCATE64 */ This really screams out...
View ArticleRe: [PATCH v5 0/2] Remove false-positive VLAs when using max()
Linus Torvalds writes: (Summary) The silly thing is, the thing we *really* want to know _is_ actually easily accessible during the early parsing, exactly like __builtin_compatible_p(): it's not really...
View ArticleRe: detecting integer constant expressions in macros
Linus Torvalds writes: (Summary) ((void*)((x) * 0l)) : (int*)1))) Ok, so I can see that (void *)((x)*0l)) turns into NULL when x is an ICE. NULL : (int *) 1) sizeof( 1 ? NULL : (int *) 1) and the rule...
View ArticleRe: detecting integer constant expressions in macros
Linus Torvalds writes: On Tue, Mar 20, 2018 at 4:07 PM, Uecker, Martin<Martin.Uecker@med.uni-goettingen.de> wrote:[...] sizeof(_Tb)])0; })) I liked your previous hack more. This is much more...
View ArticleRe: [PATCH v5 0/2] Remove false-positive VLAs when using max()
Linus Torvalds writes: (Summary) On Sat, Mar 17, 2018 at 1:07 PM, Kees Cook <keescook@chromium.org> So thanks to the diseased mind of Martin Uecker, there's a better test for "__is_constant()":...
View ArticleRe: [PATCH v5 0/2] Remove false-positive VLAs when using max()
Linus Torvalds writes: (Summary) On Tue, Mar 20, 2018 at 4:23 PM, Linus Torvalds<torvalds@linux-foundation.org> wrote:[...] even depend on any gcc extensions. Well, it does depend on...
View ArticleRe: detecting integer constant expressions in macros
Linus Torvalds writes: (Summary) That might be the right approach, even if I like how it only used standard C (although _disgusting_ standard C) without it apart from the small issue of sizeof(void)...
View Article