Linus Torvalds writes: (Summary) Honestly, I think the patches like this are disgusting:
Honestly, I think the patches like this are disgusting:
On Sun, Mar 18, 2018 at 9:10 AM, Dominik Brodowski
<linux@dominikbrodowski.net> It doesn't save all that many lines:
It doesn't save all that many lines:
19 files changed, 97 insertions(+), 106 deletions(-) 19 files changed, 97 insertions(+), 106 deletions(-) and the lines it adds are an unreadable mess compared to the lines it removes. So please keep the high/low/padding stuff in the arch wrapper, and just make them use "do_pwrite64()" and friends instead (or "kern_pwrite64()", or whatever we ended up using as the kernel naming for in-kernel system call wrappers).
for in-kernel system call wrappers).
Linus
Linus
Linus
<linux@dominikbrodowski.net> It doesn't save all that many lines:
It doesn't save all that many lines:
19 files changed, 97 insertions(+), 106 deletions(-) 19 files changed, 97 insertions(+), 106 deletions(-) and the lines it adds are an unreadable mess compared to the lines it removes. So please keep the high/low/padding stuff in the arch wrapper, and just make them use "do_pwrite64()" and friends instead (or "kern_pwrite64()", or whatever we ended up using as the kernel naming for in-kernel system call wrappers).
for in-kernel system call wrappers).
Linus
Linus
Linus