Linus Torvalds writes: (Summary) wrote:
This part is just confusing.
This part is just confusing.
First off, that comment is correct: a filesystem _can_ prevent the returning of cached data by just calling forget_cached_acl(). Note that there are two different cases: saying that you _never_ want to cache things (ACL_DONT_CACHE) and saying that there _currently_ is no cached data (ACL_NOT_CACHED).
no cached data (ACL_NOT_CACHED).
forget_cached_acl() just removes the current cache. That whole new comment of yours: + * ACL_DONT_CACHE is treated as another task updating the acl and + * remains set.
+ * remains set.
is just garbage.
is just garbage.
The code is very clear - it will only replace a ACL_NOT_CACHED entry.
[...]
prevent caching by calling forget_cached_acl.This part is just confusing.
This part is just confusing.
First off, that comment is correct: a filesystem _can_ prevent the returning of cached data by just calling forget_cached_acl(). Note that there are two different cases: saying that you _never_ want to cache things (ACL_DONT_CACHE) and saying that there _currently_ is no cached data (ACL_NOT_CACHED).
no cached data (ACL_NOT_CACHED).
forget_cached_acl() just removes the current cache. That whole new comment of yours: + * ACL_DONT_CACHE is treated as another task updating the acl and + * remains set.
+ * remains set.
is just garbage.
is just garbage.
The code is very clear - it will only replace a ACL_NOT_CACHED entry.