Quantcast
Viewing all articles
Browse latest Browse all 627

Re: [PATCH v7 3/7] fs/posix_acl: Document that get_acl respects AC ...

Linus Torvalds writes: (Summary) By all means add a comment about ACL_DONT_CACHE disabling the cache entirely.
cache entirely.
But don't _remove_ the other valid way to flush the cache, and don't make that comment above cmpxchg() be even more confusing than the code is.
is.

[...]

+ * The ACL returned by ->get_acl will be cached. Then, talk about how to invalidate the cache once it has been instantiated (forget_cached_acl()).
instantiated (forget_cached_acl()).
Don't do this idiotic "remove the valid comment just because you happened to care about the _other_ case"
happened to care about the _other_ case"
happened to care about the _other_ case"
Linus
Linus
Linus

Viewing all articles
Browse latest Browse all 627

Trending Articles