Re: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()
Linus Torvalds writes: (Summary) You're using a pointer where the lifetime has nothing to do with RCU any more. nothing to do with RCU any more. Can it be done? But you need *other* locking for it...
View ArticleRe: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()
Linus Torvalds writes: (Summary) Even if we go your way, there is *one* single user, and that one is special and needs to take a lot more care. special and needs to take a lot more care. Just roll your...
View ArticleRe: write_lock_irq(&tasklist_lock)
Linus Torvalds writes: (Summary) It covers too much, but trying to split it up has never worked well. split it up has never worked well. It's usually not a huge problem because there are so few...
View ArticleRe: write_lock_irq(&tasklist_lock)
Linus Torvalds writes: (Summary) We actually have a special rule to make it *not* be fair, in that interrupts are allowed to take the read lock if there are readers - even if there are waiting writers....
View ArticleRe: write_lock_irq(&tasklist_lock)
Linus Torvalds writes: (Summary) On Wed, May 23, 2018 at 6:05 AM Will Deacon <will.deacon@arm.com> Oh, I didn't even realize that this wasn't x86, and that there was still the very unfair rwlock...
View ArticleRe: write_lock_irq(&tasklist_lock)
Linus Torvalds writes: (Summary) On Wed, May 23, 2018 at 8:35 AM Will Deacon <will.deacon@arm.com> wrote: On Wed, May 23, 2018 at 8:35 AM Will Deacon <will.deacon@arm.com> wrote: [...] In...
View ArticleRe: semantics of rhashtable and sysvipc
Linus Torvalds writes: (Summary) But no, not with a BUG_ON(). with a BUG_ON(). If you cannot guarantee that the allocation works (using __GFP_NOFAIL is ok, for example - but it only works with small...
View ArticleRe: semantics of rhashtable and sysvipc
Linus Torvalds writes: (Summary) wrote: [...] validations[...] and rhashtable_init() can return -EINVAL. So? So? It's not going to happen, because you're not going to give garbage parameters....
View ArticleRe: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO
Linus Torvalds writes: (Summary) } =0x01234567890abcdef in the lds file, and you'll get a section that looks like this: [torvalds@i7 linux]$ objdump -h vmlinux -j .salt -s vmlinux: file format...
View ArticleRe: semantics of rhashtable and sysvipc
Linus Torvalds writes: (Summary) On Thu, May 24, 2018 at 10:23 AM Davidlohr Bueso <dave@stgolabs.net> I'm not sure that matters, but right now, if you have nelem_hint set and a min_size, the...
View ArticleRe: semantics of rhashtable and sysvipc
Linus Torvalds writes: (Summary) We wouldn't expect this to ever happen in practice, and as you say, if it *does* happen, the size of the hash array is the last of our problems. is the last of our...
View ArticleRe: [PATCH 3/6] lib/bucket_locks: use kvmalloc_array()
Linus Torvalds writes: (Summary) wrote: [...] gfp);[...] gfp); gfp); Side note: how about we just move that "gfpflags_allow_blocking()" into kvmalloc() instead, and make kvmalloc() generally usable?...
View ArticleRe: [PATCH -next 0/6] rhashtable: guarantee first allocation
Linus Torvalds writes: (Summary) On Thu, May 24, 2018 at 2:28 PM Davidlohr Bueso <dave@stgolabs.net> wrote: [...] 10 files changed, 79 insertions(+), 86 deletions(-) I certainly can't complain...
View ArticleRe: [PATCH] proc: prevent a task from writing on its own /proc/*/mem
Linus Torvalds writes: (Summary) On Sat, May 26, 2018 at 5:32 PM Kees Cook <keescook@chromium.org> wrote: On Sat, May 26, 2018 at 5:32 PM Kees Cook <keescook@chromium.org> Thus commit...
View ArticleLinux 4.17-rc7
Linus Torvalds writes: (Summary) Ruhl (1): IB/hfi1: Use after free race condition in send context error path Michael Neuling (1): powerpc/64s: Clear PCR on boot Michal Hocko (2): mm, memory_hotplug:...
View ArticleRe: [GIT PULL] afs: A couple of fixes
Linus Torvalds writes: (Summary) On Tue, May 29, 2018 at 8:55 AM David Howells <dhowells@redhat.com> That _was_ a tag, but it wasn't signed. Hmm. That _was_ a tag, but it wasn't signed. I don't...
View ArticleRe: [PATCH 3/6] lib/bucket_locks: use kvmalloc_array()
Linus Torvalds writes: (Summary) It basically says "this function is garbage, so let me warn about the fact that I'm a moron". And the *ONLY* thing that warning has ever caused is just stupid code that...
View ArticleRe: LKMM litmus test for Roman Penyaev's rcu-rr
Linus Torvalds writes: (Summary) Does it? Does it? Can't we simplify the whole sequence as basically Can't we simplify the whole sequence as basically A if (!B) D for that "not B" case, and just think...
View ArticleRe: [git pull] Input updates for v4.17-rc7
Linus Torvalds writes: On Tue, May 29, 2018 at 6:38 PM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: wrote:[...] native RMI/SMbus.[...] them till next release. Hmm. The elan driver stack...
View ArticleRe: LKMM litmus test for Roman Penyaev's rcu-rr
Linus Torvalds writes: (Summary) They are NOT THE SAME. are NOT THE SAME. It really should be: It really should be:[...] D No it really really shouldn't. No it really really shouldn't. There are two...
View Article