Linus Torvalds writes: (Summary) wrote:
[ deleted the bad things ]
[ deleted the bad things ]
Should we just instead get the ref to the dentry before dropping the lock, so that nobody else can get to dentry_kill?
lock, so that nobody else can get to dentry_kill?
This is too subtle, and your fix to check d_lockref.count < Ok, I agree, looks like lock_parent should just re-check that thing that it already checked earler, but that now might be true again because of we dropped d_lock.
because of we dropped d_lock.
Linus
Linus
Linus
[...]
we drop dentry->d_lock[ deleted the bad things ]
[ deleted the bad things ]
Should we just instead get the ref to the dentry before dropping the lock, so that nobody else can get to dentry_kill?
lock, so that nobody else can get to dentry_kill?
This is too subtle, and your fix to check d_lockref.count < Ok, I agree, looks like lock_parent should just re-check that thing that it already checked earler, but that now might be true again because of we dropped d_lock.
because of we dropped d_lock.
Linus
Linus
Linus