Quantcast
Channel: lkml.org : Ganesh Sittampalam
Viewing all articles
Browse latest Browse all 627

Re: [RFC PATCH for 4.18 1/2] rseq: validate rseq_cs fields are < T ...

$
0
0
Linus Torvalds writes: (Summary) wrote:

[...]

You simply can't have it both ways.
Put another way.
Put another way.
This is ok in the native path:
This is ok in the native path:
        if ((unsigned long) rseq_cs->abort_ip != rseq_cs->abort_ip)
                return -EINVAL;

But it is NOT OK to say "the rseq system call doesn't have any compat
syscall, but we'll do that compat check in the native case, because we
worry about compat issues". Either you worry about compat issues (and have a
compat syscall), or you don't.

The whole "let's not do a compat syscall, but then check compat issues
at run-time in the native system call because compat processes will
use it" is braindamage.

Viewing all articles
Browse latest Browse all 627

Trending Articles