Linus Torvalds writes: (Summary)
The array_size() conversions, in contrast, actually result in *LESS*
legible code, in worse code generation, and absolutely no upside for
cases like the above.
cases like the above.
To make up for it, there's some conversions *away* from nonsensical expressions: To make up for it, there's some conversions *away* from nonsensical expressions: - hc_name = kzalloc(sizeof(char) * (HSMMC_NAME_LEN + 1), GFP_KERNEL); but I _really_ think you were way too eager to move to array_size() even when it made no sense what-so-ever.
even when it made no sense what-so-ever.
But at least with the kcalloc()/kmalloc_array() conversions now preferred, those crazy cases are now a minority rather than "most of the patch makes code worse".
the patch makes code worse".
I am *not* looking forward to the conflicts this causes, but maybe it won't be too bad.
cases like the above.
To make up for it, there's some conversions *away* from nonsensical expressions: To make up for it, there's some conversions *away* from nonsensical expressions: - hc_name = kzalloc(sizeof(char) * (HSMMC_NAME_LEN + 1), GFP_KERNEL); but I _really_ think you were way too eager to move to array_size() even when it made no sense what-so-ever.
even when it made no sense what-so-ever.
But at least with the kcalloc()/kmalloc_array() conversions now preferred, those crazy cases are now a minority rather than "most of the patch makes code worse".
the patch makes code worse".
I am *not* looking forward to the conflicts this causes, but maybe it won't be too bad.