Linus Torvalds writes: (Summary) wrote:
That still seems broken.
That still seems broken.
The *natural* thing to do would seem to be to tie the hash to the printk state, kind of like the percpu buffers that safe_printk() and friends use.
friends use.
Modifying the hash global is fundamentally broken, since some problem that happens *during* tracing - on another CPU entirely - would now have the hashing disabled.
have the hashing disabled.
So at the *very* least this would need to be percpu logic, but even that is honestly broken since an NMI might come in and want to printk too.
too.
Why don't you just use %px?
[...]
hash...That still seems broken.
That still seems broken.
The *natural* thing to do would seem to be to tie the hash to the printk state, kind of like the percpu buffers that safe_printk() and friends use.
friends use.
Modifying the hash global is fundamentally broken, since some problem that happens *during* tracing - on another CPU entirely - would now have the hashing disabled.
have the hashing disabled.
So at the *very* least this would need to be percpu logic, but even that is honestly broken since an NMI might come in and want to printk too.
too.
Why don't you just use %px?