Re: [PATCH v1] devpts: resolve devpts bind-mounts

Linus Torvalds writes: (Summary) wrote:

[...]

dput(path.dentry);
why did you duplicate the devpts_ptmx_path() and then do that odd error handling?
error handling?

We only go into that "if()" statement if
DEVPTS_SB(filp->f_path.mnt->mnt_sb) == fsi, so then when you do that
"put path and re-get it, and go to check_devpts_sb", the
check_devpts_sb won't actually _do_ anything, because it has

> -       if (err) {
> +       if (path.mnt->mnt_sb->s_magic != DEVPTS_SUPER_MAGIC) {
> +               if (err) {
> +               }
>