Linus Torvalds writes: (Summary) wrote:
To be honest., Andy's approach has the advantage that all the synchronization we do for modules still works.
synchronization we do for modules still works.
In particular, we have module loading logic where we synchronize loading of modules with the same name, so that two things that do request_module() concurrently will not lead to two modules being loaded.
loaded.
See that whole "module_mutex" thing, and the logic in (for example) "add_unformed_module()".
"add_unformed_module()".
Andrei's patch short-circuits the module loading before that, so if you have two concurrent request_module() calls, you'll end up with no serialization, and two executables.
serialization, and two executables.
So maybe Andy is right.
[...]
that has had its signature verified, not the file!To be honest., Andy's approach has the advantage that all the synchronization we do for modules still works.
synchronization we do for modules still works.
In particular, we have module loading logic where we synchronize loading of modules with the same name, so that two things that do request_module() concurrently will not lead to two modules being loaded.
loaded.
See that whole "module_mutex" thing, and the logic in (for example) "add_unformed_module()".
"add_unformed_module()".
Andrei's patch short-circuits the module loading before that, so if you have two concurrent request_module() calls, you'll end up with no serialization, and two executables.
serialization, and two executables.
So maybe Andy is right.